Skip to content

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 25, 2025

There are compile errors on Apple M1 machines, see
gazebosim/gz-sim#1362 (comment)

To fix the build, I ported the changes from upstream backward repo::
https://github.com/bombela/backward-cpp/blob/master/backward.hpp#L4220-L4225

The alternative is to update the backward.hpp file with the latest version from upstream, which I tried that and noticed quite a few changes between our copy and the latest version. So I took the safest route and just applied minimal changes to fix the build.


This is an automatic backport of pull request #161 done by Mergify.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
(cherry picked from commit ae261dc)
@mergify mergify bot requested a review from nkoenig as a code owner August 25, 2025 07:11
@mergify mergify bot mentioned this pull request Aug 25, 2025
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Aug 25, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Aug 25, 2025
@scpeters scpeters merged commit 5991bc9 into ign-launch5 Aug 25, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Aug 25, 2025
@scpeters scpeters deleted the mergify/bp/ign-launch5/pr-161 branch August 25, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏯 fortress Ignition Fortress

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants